Bug 227959 - Fix type of exceptions thrown in the WebAudio API
Summary: Fix type of exceptions thrown in the WebAudio API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-14 10:39 PDT by Chris Dumez
Modified: 2021-07-14 13:40 PDT (History)
15 users (show)

See Also:

Attachments
Patch (65.27 KB, patch)
2021-07-14 11:37 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-07-14 10:39:41 PDT 
AudioNode constructors should throw a NotSupportedError when the requested number of channels is too large. Currently, WebKit throws an IndexSizeError but this doesn't match Blink / Gecko and causes some WPT tests to fail.
Comment 1 Chris Dumez 2021-07-14 11:37:45 PDT 
Created attachment 433513 [details]
Patch
Comment 2 Yusuke Suzuki 2021-07-14 13:12:59 PDT 
Comment on attachment 433513 [details]
Patch

r=me
Comment 3 EWS 2021-07-14 13:39:50 PDT 
Committed r279917 (239666@main): <https://commits.webkit.org/239666@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433513 [details].
Comment 4 Radar WebKit Bug Importer 2021-07-14 13:40:18 PDT 
<rdar://problem/80594511>