Summary: | [WK2] Push OS state dumping logic down from WebProcess to AuxiliaryProcess | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||
Component: | WebKit2 | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, kkinnunen, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 227917 | ||||||||
Attachments: |
|
Description
Wenson Hsieh
2021-07-13 12:59:39 PDT
Created attachment 433445 [details]
Patch
Comment on attachment 433445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433445&action=review > Source/WebKit/WebProcess/WebProcess.h:413 > + RetainPtr<NSDictionary> dictionaryForStateDumper() const final; Can we make it more clear in the name what this is about? Every time I have encountered this function before it was wildly unclear what state was being dumped and why. Comment on attachment 433445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433445&action=review >> Source/WebKit/WebProcess/WebProcess.h:413 >> + RetainPtr<NSDictionary> dictionaryForStateDumper() const final; > > Can we make it more clear in the name what this is about? Every time I have encountered this function before it was wildly unclear what state was being dumped and why. Sounds good! I'll rename this to `additionalStateForDiagnosticReport` as we discussed on Slack. Created attachment 433470 [details]
Rename method
Committed r279902 (239651@main): <https://commits.webkit.org/239651@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433470 [details]. |