Bug 227916

Summary: [WK2] Push OS state dumping logic down from WebProcess to AuxiliaryProcess
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit2Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, kkinnunen, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 227917    
Attachments:
Description Flags
Patch
none
Rename method ews-feeder: commit-queue-

Wenson Hsieh
Reported 2021-07-13 12:59:39 PDT
...with the intention of using it for `GPUProcess` as well, in a future patch.
Attachments
Patch (12.40 KB, patch)
2021-07-13 13:16 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Rename method (12.45 KB, patch)
2021-07-13 18:41 PDT, Wenson Hsieh 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-07-13 13:16:46 PDT
Created attachment 433445 [details] Patch
Tim Horton
Comment 2 2021-07-13 18:24:51 PDT
Comment on attachment 433445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433445&action=review > Source/WebKit/WebProcess/WebProcess.h:413 > + RetainPtr<NSDictionary> dictionaryForStateDumper() const final; Can we make it more clear in the name what this is about? Every time I have encountered this function before it was wildly unclear what state was being dumped and why.
Wenson Hsieh
Comment 3 2021-07-13 18:37:35 PDT
Comment on attachment 433445 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433445&action=review >> Source/WebKit/WebProcess/WebProcess.h:413 >> + RetainPtr<NSDictionary> dictionaryForStateDumper() const final; > > Can we make it more clear in the name what this is about? Every time I have encountered this function before it was wildly unclear what state was being dumped and why. Sounds good! I'll rename this to `additionalStateForDiagnosticReport` as we discussed on Slack.
Wenson Hsieh
Comment 4 2021-07-13 18:41:48 PDT
Created attachment 433470 [details] Rename method
EWS
Comment 5 2021-07-13 19:42:19 PDT
Committed r279902 (239651@main): <https://commits.webkit.org/239651@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433470 [details].
Radar WebKit Bug Importer
Comment 6 2021-07-13 19:43:17 PDT
<rdar://problem/80552993>
Note You need to log in before you can comment on or make changes to this bug.