Bug 227905

Summary: Remove USE_64KB_PAGE_BLOCK
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, benjamin, bugs-noreply, cdumez, cmarcelo, ews-watchlist, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217989
https://bugs.webkit.org/show_bug.cgi?id=244036
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2021-07-13 08:38:18 PDT
I added the USE_64KB_PAGE_BLOCK build option in bug #217989 for use by RHEL. But going forward, I don't need it anymore, and can maintain it downstream where it is needed. (This option might also be useful to SUSE, but they already don't use it, so won't miss it.) I've seen users who don't understand the consequences of this option enabling it on x86_64, even though there are serious negative consequences and zero benefits to using it. So let's get rid of it.
Attachments
Patch (5.54 KB, patch)
2021-07-13 08:42 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2021-07-13 08:42:42 PDT
Created attachment 433407 [details] Patch
Yusuke Suzuki
Comment 2 2021-07-13 11:35:13 PDT
Comment on attachment 433407 [details] Patch r=me
EWS
Comment 3 2021-07-13 14:53:28 PDT
Committed r279892 (239643@main): <https://commits.webkit.org/239643@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433407 [details].
Note You need to log in before you can comment on or make changes to this bug.