Summary: | REGRESSION (r279806): [ iOS/macOS ] Multiple Canvas tests flaky crash, flaky fail | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Hutchison <ehutchison> | ||||||||||
Component: | Text | Assignee: | Eric Hutchison <ehutchison> | ||||||||||
Status: | RESOLVED DUPLICATE | ||||||||||||
Severity: | Normal | CC: | ap, ayumi_kojima, ehutchison, jenner, mmaxfield, simon.fraser, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=227805 https://bugs.webkit.org/show_bug.cgi?id=227890 https://bugs.webkit.org/show_bug.cgi?id=228034 https://bugs.webkit.org/show_bug.cgi?id=229043 |
||||||||||||
Attachments: |
|
Description
Eric Hutchison
2021-07-12 11:38:07 PDT
Created attachment 433359 [details]
Update Test Expectations
It's important that we file a bug on the crash itself with more info. Comment on attachment 433359 [details] Update Test Expectations Clearing flags on attachment: 433359 Committed r279853 (239607@main): <https://commits.webkit.org/239607@main> Reproduced crash on r279831 with run-webkit-test --iOS-simulator --iterations 200 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --debug-rwt-logging --no-retry --force --no-build -f fast/canvas/canvas-overloads-strokeText.html. Crash-log.txt contains: No crash log found for com.apple.WebKit.WebContent.Development:5872. stdout: stderr: com.apple.WebKit.WebContent.Development terminated (pid 5872) because the process crashed .stderr.text contains: com.apple.WebKit.WebContent.Development terminated (pid 5872) because the process crashed reproduced crash on r279806 with same command as above. Crash log text: No crash log found for com.apple.WebKit.WebContent.Development:7250. stdout: stderr: com.apple.WebKit.WebContent.Development terminated (pid 7250) because the process crashed Stderr text: com.apple.WebKit.WebContent.Development terminated (pid 7250) because the process crashed Test did not crash on r279805. It looks like this also affects macOS: https://results.webkit.org/?suite=layout-tests&test=fast%2Fcanvas%2Fcanvas-overloads-strokeText.html&platform=ios&platform=mac Created attachment 433538 [details]
Patch
Updating test expectations for MacOS wk2 I was able to reproduce the crash using run-webkit-tests fast/canvas/canvas-overloads-strokeText.html --iterations 500 --exit-after-n-crashes-or-timeouts 2 Comment on attachment 433538 [details] Patch Clearing flags on attachment: 433538 Committed r279932 (239677@main): <https://commits.webkit.org/239677@main> This regression also impacts inspector/canvas/requestClientNodes-css.html as a flaky timeout. Adding it here and updating test expectations. Diff: --- /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk2/build/layout-test-results/inspector/canvas/requestClientNodes-css-expected.txt +++ /Volumes/Data/worker/bigsur-release-applesilicon-tests-wk2/build/layout-test-results/inspector/canvas/requestClientNodes-css-actual.txt @@ -1,13 +1,5 @@ -Test that CanvasAgent tracks changes in the client nodes of a CSS canvas. +#PID UNRESPONSIVE - WebKitTestRunner (pid 13414) +FAIL: Timed out waiting for notifyDone to be called - -== Running test suite: Canvas.requestClientNodes.CSS --- Running test case: Canvas.requestClientNodes.CSS.Create -PASS: Canvas with created client should have CSS name "css-canvas". -PASS: There should be one client node. -PASS: Client node "div" is valid. - --- Running test case: Canvas.requestClientNodes.CSS.Destroy -PASS: Canvas with destroyed client should have CSS name "css-canvas". -PASS: There should be no client nodes. - +#EOF +#EOF Created attachment 433702 [details]
Update Test Expectations
Created attachment 433704 [details]
Update Test Expectations
History link "inspector/canvas/requestClientNodes-css.html": https://results.webkit.org/?suite=layout-tests&test=inspector%2Fcanvas%2FrequestClientNodes-css.html Comment on attachment 433704 [details] Update Test Expectations Clearing flags on attachment: 433704 Committed r280002 (239744@main): <https://commits.webkit.org/239744@main> *** Bug 227929 has been marked as a duplicate of this bug. *** *** Bug 227890 has been marked as a duplicate of this bug. *** *** Bug 228034 has been marked as a duplicate of this bug. *** Update test expectations for https://bugs.webkit.org/show_bug.cgi?id=227881 in https://trac.webkit.org/changeset/280150/webkit. Test is inspector/canvas/recording-webgl-snapshots.html inspector/canvas/recording-2d-memoryLimit.html and inspector/canvas/recording-2d-full.html crashing due to this regression. Updated test expectations to skip these tests at https://trac.webkit.org/changeset/280152/webkit. *** Bug 228131 has been marked as a duplicate of this bug. *** inspector/canvas/recording-bitmaprenderer-memoryLimit.html is also affected by this bug. Also affected: inspector/canvas/updateShader-webgpu.html inspector/canvas/recording-html-2d.html Updated test expectations at https://trac.webkit.org/changeset/280403/webkit *** This bug has been marked as a duplicate of bug 228216 *** |