Bug 227868

Summary: [GTK][WPE] Support drawing scrollbar corner
Product: WebKit Reporter: Alice Mikhaylenko <alicem>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, changseok, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, mcatanzaro, pdr, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
aperez: review+
Patch
none
Patch ews-feeder: commit-queue-

Description Alice Mikhaylenko 2021-07-12 03:13:57 PDT 
See the patch.
Comment 1 Alice Mikhaylenko 2021-07-12 03:18:48 PDT 
Created attachment 433308 [details]
Patch
Comment 2 Alice Mikhaylenko 2021-07-12 03:49:20 PDT 
Created attachment 433309 [details]
Patch

Missed a use outside WebCore.
Comment 3 Adrian Perez 2021-07-12 04:32:53 PDT 
Comment on attachment 433309 [details]
Patch

Patch LGTM, we may want to have someone from Apple confirm that the
additional parameter passed around is okay for them :)
Comment 4 Adrian Perez 2021-07-12 04:34:03 PDT 
Ah, and please add the [WPE] in the ChangeLog summary line; the port
uses the same code to paint scrollbars nowadays.
Comment 5 Alice Mikhaylenko 2021-07-12 04:37:37 PDT 
Yeah, I noticed the macOS scroll corners were slightly broken with scrollbars on the left since there's no way to check that without the new parameter. :) I have no idea how to request RTL flip there though (it uses native scrollbars) so didn't update it.
Comment 6 Alice Mikhaylenko 2021-07-12 04:38:26 PDT 
Created attachment 433310 [details]
Patch

Added [WPE].
Comment 7 Alice Mikhaylenko 2021-07-12 04:39:43 PDT 
Created attachment 433311 [details]
Patch

And of course I forgot the second changelog in WebKit/. Updated too.
Comment 8 Michael Catanzaro 2021-07-12 05:48:30 PDT 
Comment on attachment 433311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433311&action=review

> Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1956
> -        ScrollbarTheme::theme().paintScrollCorner(graphicsContext, scrollCornerRect);
> +        ScrollbarTheme::theme().paintScrollCorner(*this, graphicsContext, scrollCornerRect);

*Technically* this line of the changeset requires owner approval, but it's such a small unproblematic change, only intended to keep this code building, that I think we can skip the formality in this case.
Comment 9 Alice Mikhaylenko 2021-07-12 06:19:16 PDT 
Ah yeah, flaky tests again.
Comment 10 EWS 2021-07-12 07:26:51 PDT 
Committed r279826 (239587@main): <https://commits.webkit.org/239587@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433311 [details].