Bug 227860

Summary: [Cocoa] Incorrect deprecation declaration for -[WKWebView closeAllMediaPresentations:]
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, eric.carlson, james.savage, jean-yves.avenard, katherine_cheney, peng.liu6, sam, thorton, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jer Noble 2021-07-11 10:47:34 PDT
[Cocoa] Incorrect deprecation declaration for -[WKWebView closeAllMediaPresentations:]
Comment 1 Jer Noble 2021-07-11 10:48:02 PDT
<rdar://80376777>
Comment 2 Jer Noble 2021-07-11 10:53:26 PDT
Created attachment 433290 [details]
Patch
Comment 3 Brady Eidson 2021-07-11 14:53:22 PDT
Comment on attachment 433290 [details]
Patch

What does this due to the swift case in betas that have shipped?
Comment 4 Jer Noble 2021-07-11 15:03:45 PDT
(In reply to Brady Eidson from comment #3)
> Comment on attachment 433290 [details]
> Patch
> 
> What does this due to the swift case in betas that have shipped?

It should restore the .closeAllMediaPresentations() method to the swift mapping header. The deprecated API declaration was never exposed to swift, so to swift code, it appeared as if we just removed the API entirely. See: http://codeworkshop.net/objc-diff/sdkdiffs/ios/15.0/WebKit.html
Comment 5 Brady Eidson 2021-07-11 17:29:35 PDT
Great, then the r+ comes with my r+ too :P
Comment 6 EWS 2021-07-12 10:10:32 PDT
Committed r279833 (239594@main): <https://commits.webkit.org/239594@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433290 [details].