Bug 227817

Summary: [watchOS] Tapping "Done" in Scribble when focusing an editable element should dismiss Quickboard
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: FormsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Wenson Hsieh
Reported 2021-07-08 15:20:19 PDT
rdar://79931134
Attachments
Patch (4.31 KB, patch)
2021-07-08 15:34 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (4.31 KB, patch)
2021-07-08 16:01 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-07-08 15:34:08 PDT
Created attachment 433171 [details] Patch
Wenson Hsieh
Comment 2 2021-07-08 15:57:23 PDT
Comment on attachment 433171 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433171&action=review Thanks for the review! > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6911 > + [[controller transitionCoordinator] animateAlongsideTransition:nil completion:[dispatchDidDismiss = WTFMove(dispatchDidDismiss)] (id <UIViewControllerTransitionCoordinatorContext>) mutable { (Devin pointed out that this `mutable` is unnecessary).
Wenson Hsieh
Comment 3 2021-07-08 16:01:59 PDT
Created attachment 433177 [details] Patch
EWS
Comment 4 2021-07-08 17:04:56 PDT
Committed r279764 (239534@main): <https://commits.webkit.org/239534@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433177 [details].
Note You need to log in before you can comment on or make changes to this bug.