Bug 227817

Summary:

[watchOS] Tapping "Done" in Scribble when focusing an editable element should dismiss Quickboard

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

Forms

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, hi, megan_gardner, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Wenson Hsieh 2021-07-08 15:20:19 PDT

rdar://79931134

Comment 1 Wenson Hsieh 2021-07-08 15:34:08 PDT

Created attachment 433171 [details]
Patch

Comment 2 Wenson Hsieh 2021-07-08 15:57:23 PDT

Comment on attachment 433171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433171&action=review

Thanks for the review!

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6911
> +            [[controller transitionCoordinator] animateAlongsideTransition:nil completion:[dispatchDidDismiss = WTFMove(dispatchDidDismiss)] (id <UIViewControllerTransitionCoordinatorContext>) mutable {

(Devin pointed out that this `mutable` is unnecessary).

Comment 3 Wenson Hsieh 2021-07-08 16:01:59 PDT

Created attachment 433177 [details]
Patch

Comment 4 EWS 2021-07-08 17:04:56 PDT

Committed r279764 (239534@main): <https://commits.webkit.org/239534@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433177 [details].