Summary: | add logging for GraphicsLayerCA::m_uncommittedChanges | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Cameron McCormack (:heycam) <heycam> | ||||
Component: | Compositing | Assignee: | Cameron McCormack (:heycam) <heycam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Local Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Cameron McCormack (:heycam)
2021-07-07 17:53:42 PDT
Created attachment 433102 [details]
Patch
Comment on attachment 433102 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433102&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:4136 > +const char* GraphicsLayerCA::layerChangeAsString(LayerChange layerChange) This is better implemented as TextStream& operator<<(TextStream&, LayerChange) I wanted to but struggled with the enum being private. Comment on attachment 433102 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433102&action=review > Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:4207 > + bool first = true; > + while (layerChangeFlags) { > + if (layerChangeFlags & bit) { > + textStream << (first ? " " : ", ") << layerChangeAsString(static_cast<LayerChange>(bit)); > + first = false; > + } > + layerChangeFlags &= ~bit; > + bit <<= 1; > + } > + textStream << " }"; Shame that LayerChangeFlags isn' an OptionSet<> because they you wouldn't need this either. Will do that later. https://bugs.webkit.org/show_bug.cgi?id=227787 Committed r279712 (239504@main): <https://commits.webkit.org/239504@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433102 [details]. |