Bug 227782

Summary:

Heap::waitForCollector() needs to set m_mutatorDidRun.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	saam: review+

Description Mark Lam 2021-07-07 17:36:39 PDT

Heap::waitForCollector() is one of 2 clients of Heap::stopIfNecessarySlow(unsigned oldState).  The other client, Heap::stopIfNecessarySlow() sets m_mutatorDidRun to true after calling Heap::stopIfNecessarySlow(unsigned oldState).  Heap::waitForCollector() needs to do the same.  Constraint solvers rely on this.

rdar://78326474

Comment 1 Mark Lam 2021-07-07 17:41:45 PDT

Created attachment 433099 [details]
proposed patch.

Comment 2 Mark Lam 2021-07-07 17:55:16 PDT

Thanks for the review.  Landed in r279689: <http://trac.webkit.org/r279689>.