Summary: | Add ScriptController::updateSecurityOrigin | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
Component: | DOM | Assignee: | Adam Barth <abarth> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Adam Barth
2008-12-09 21:35:01 PST
Created attachment 25912 [details]
patch
For those keeping score at home, this method corresponds to / replaces SecriptController::setDomain in http://src.chromium.org/viewvc/chrome/trunk/src/webkit/port/bindings/v8/ScriptController.h?view=markup Comment on attachment 25912 [details] patch > securityOrigin()->setDomainFromDOM(newDomain); > + if (m_frame) > + m_frame->script()->updateSecurityOrigin(); The indentation looks odd here. > securityOrigin()->setDomainFromDOM(newDomain); > + if (m_frame) > + m_frame->script()->updateSecurityOrigin(); And here. r=me Comment on attachment 25912 [details] patch >diff --git a/WebCore/dom/Document.cpp b/WebCore/dom/Document.cpp ... >+ if (m_frame) >+ m_frame->script()->updateSecurityOrigin(); > return; ... >+ if (m_frame) >+ m_frame->script()->updateSecurityOrigin(); > } FYI: indentation looks to be off by one space. > FYI: indentation looks to be off by one space.
Thanks. I think I fixed this before landing.
|