Bug 227747

Summary:

XPC services should release their os transaction when given a SIGTERM signal

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

New Bugs

Assignee:

Alex Christensen <achristensen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ggaren, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Alex Christensen 2021-07-07 09:17:31 PDT

XPC services should release their os transaction when given a SIGTERM signal

Comment 1 Alex Christensen 2021-07-07 09:21:38 PDT

Created attachment 433035 [details]
Patch

Comment 2 Alex Christensen 2021-07-07 09:21:41 PDT

<rdar://problem/72430454>

Comment 3 Geoffrey Garen 2021-07-07 09:41:54 PDT

Comment on attachment 433035 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433035&action=review

r=me

> Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.h:105
> +    signal(SIGTERM, releaseOSTransaction);

FWIW, I like using no-capture lambdas in cases like this.

Comment 4 Alex Christensen 2021-07-07 09:51:27 PDT

Created attachment 433038 [details]
Patch

Comment 5 EWS 2021-07-07 10:32:26 PDT

Committed r279647 (239460@main): <https://commits.webkit.org/239460@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433038 [details].

Comment 6 Alex Christensen 2021-07-13 13:56:55 PDT

Reverted in r279890