Summary: | Add WKHoverPlatter and some knobs to tweak its appearance | ||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||||||||||
Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||
Severity: | Normal | CC: | dino, sam, webkit-bug-importer, wenson_hsieh | ||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||
Attachments: |
|
Description
Tim Horton
2021-07-06 21:45:20 PDT
Created attachment 433008 [details]
Patch
Created attachment 433009 [details]
Patch
Created attachment 433012 [details]
Patch
Created attachment 433013 [details]
Patch
Created attachment 433018 [details]
Patch
Created attachment 433019 [details]
Patch
Comment on attachment 433019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433019&action=review > Source/WebKit/UIProcess/ios/WKHoverPlatter.mm:40 > + RetainPtr<CASpringAnimation> spring = adoptNS([[CASpringAnimation alloc] init]); auto? > Source/WebKit/UIProcess/ios/WKHoverPlatter.mm:49 > + RetainPtr<CABasicAnimation> ease = adoptNS([[CABasicAnimation alloc] init]); auto? > Source/WebKit/UIProcess/ios/WKHoverPlatter.mm:58 > + RetainPtr<CABasicAnimation> animation = createBaseAnimation(); auto? > Source/WebKit/UIProcess/ios/WKHoverPlatter.mm:189 > + RetainPtr<CGPathRef> inflatedPath = WebCore::PathUtilities::pathWithShrinkWrappedRects(inflatedIndicatedRects, parameters.platterCornerRadius).platformPath(); auto? Created attachment 433096 [details]
Patch
Created attachment 433117 [details]
Patch
Committed r279711 (239503@main): <https://commits.webkit.org/239503@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433117 [details]. |