Bug 22773 – pauseAnimationAtTimeOnElementWithId() does not work with animations using multiple keyframes

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Pierre-Olivier Latour]

pauseAnimationAtTimeOnElementWithId() does not work with animations using multiple keyframes

[Pierre-Olivier Latour]

Created attachment 25909 [details]
Patch

The issue is that KeyframeAnimation::animate() does not compute the ellapsed time exactly the same way that AnimationBase::progress() does.

[Simon Fraser (smfr)]

I think the testcase should be a text test (dumpAsText()), and should put "PASS" or "FAIL" in the document rather than throwing.

[Darin Adler]

Comment on attachment 25909 [details]
Patch

Could we change this so that KeyframeAnimation::animate() shared more code with AnimationBase::progress() so they can't get out of sync?

r=me as-is

[Pierre-Olivier Latour]

> I think the testcase should be a text test (dumpAsText()), and should put
> "PASS" or "FAIL" in the document rather than throwing.

If this test fails, the render tree output will be different.

Throwing just happens if the animation does not exist in the first place, which is not what this test looks at. It's also consistent with the other DRT animation API tests added so far.

[Pierre-Olivier Latour]

(In reply to comment #3)
> (From update of attachment 25909 [details] [review])
> Could we change this so that KeyframeAnimation::animate() shared more code with
> AnimationBase::progress() so they can't get out of sync?

Absolutely, we have a radar on this, Chris will look at it.

[Pierre-Olivier Latour]

Sending        LayoutTests/ChangeLog
Adding         LayoutTests/animations/animation-drt-api-multiple-keyframes.html
Adding         LayoutTests/platform/mac/animations/animation-drt-api-multiple-keyframes-expected.checksum
Adding  (bin)  LayoutTests/platform/mac/animations/animation-drt-api-multiple-keyframes-expected.png
Adding         LayoutTests/platform/mac/animations/animation-drt-api-multiple-keyframes-expected.txt
Sending        LayoutTests/platform/win/Skipped
Sending        WebCore/ChangeLog
Sending        WebCore/page/animation/KeyframeAnimation.cpp
Transmitting file data ........
Committed revision 39176.