Bug 227726

Summary: _WKWebAuthenticationPanel is returning the wrong operation type in clientDataJSON
Product: WebKit Reporter: Garrett Davidson <garrett_davidson>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, katherine_cheney, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Garrett Davidson
Reported 2021-07-06 15:17:44 PDT
_WKWebAuthenticationPanel is returning the wrong operation type in clientDataJSON
Attachments
Patch (2.14 KB, patch)
2021-07-06 15:19 PDT, Garrett Davidson 		no flags
DetailsFormatted DiffDiff
Patch (5.08 KB, patch)
2021-07-07 13:51 PDT, Garrett Davidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Garrett Davidson
Comment 1 2021-07-06 15:19:22 PDT
Created attachment 432981 [details] Patch
Garrett Davidson
Comment 2 2021-07-06 15:19:24 PDT
<rdar://problem/80073404>
Brent Fulgham
Comment 3 2021-07-06 15:37:27 PDT
Comment on attachment 432981 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432981&action=review We should test that the clientDataJSON is returning the right thing. Could you add a TestWebKitAPI test to OpenSource/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm that confirms that the JSON blob is right? > Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:526 > + auto clientDataJSON = produceClientDataJson(_WKWebAuthenticationTypeGet, challenge, origin); Oops!
Garrett Davidson
Comment 4 2021-07-07 13:51:15 PDT
Created attachment 433069 [details] Patch
Kate Cheney
Comment 5 2021-07-07 15:00:21 PDT
Comment on attachment 433069 [details] Patch r=me pending EWS
EWS
Comment 6 2021-07-08 10:13:46 PDT
Committed r279727 (239514@main): <https://commits.webkit.org/239514@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433069 [details].
Note You need to log in before you can comment on or make changes to this bug.