Bug 227726 - _WKWebAuthenticationPanel is returning the wrong operation type in clientDataJSON
Summary: _WKWebAuthenticationPanel is returning the wrong operation type in clientData...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-06 15:17 PDT by Garrett Davidson
Modified: 2021-07-08 10:13 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.14 KB, patch)
2021-07-06 15:19 PDT, Garrett Davidson 		no flags Details | Formatted Diff | Diff
Patch (5.08 KB, patch)
2021-07-07 13:51 PDT, Garrett Davidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Garrett Davidson 2021-07-06 15:17:44 PDT 
_WKWebAuthenticationPanel is returning the wrong operation type in clientDataJSON
Comment 1 Garrett Davidson 2021-07-06 15:19:22 PDT 
Created attachment 432981 [details]
Patch
Comment 2 Garrett Davidson 2021-07-06 15:19:24 PDT 
<rdar://problem/80073404>
Comment 3 Brent Fulgham 2021-07-06 15:37:27 PDT 
Comment on attachment 432981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432981&action=review

We should test that the clientDataJSON is returning the right thing. Could you add a TestWebKitAPI test to OpenSource/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm that confirms that the JSON blob is right?

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:526
> +    auto clientDataJSON = produceClientDataJson(_WKWebAuthenticationTypeGet, challenge, origin);

Oops!
Comment 4 Garrett Davidson 2021-07-07 13:51:15 PDT 
Created attachment 433069 [details]
Patch
Comment 5 Kate Cheney 2021-07-07 15:00:21 PDT 
Comment on attachment 433069 [details]
Patch

r=me pending EWS
Comment 6 EWS 2021-07-08 10:13:46 PDT 
Committed r279727 (239514@main): <https://commits.webkit.org/239514@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433069 [details].