Summary: | _WKWebAuthenticationPanel escapes slashes in origin | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Garrett Davidson <garrett_davidson> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | bfulgham, katherine_cheney, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Garrett Davidson
2021-07-06 15:04:23 PDT
Created attachment 432979 [details]
Patch
Comment on attachment 432979 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432979&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:76 > + return [NSJSONSerialization dataWithJSONObject:dictionary.get() options:(NSJSONWritingSortedKeys | NSJSONWritingWithoutEscapingSlashes) error:nil]; Seems like we should add a test of some kind to make sure we don't break this. Could you add a TestWebKitAPI test to OpenSource/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm that confirms that the JSON blob is right? Created attachment 433143 [details]
Patch
Comment on attachment 433143 [details]
Patch
r=me
Committed r279856 (239610@main): <https://commits.webkit.org/239610@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433143 [details]. |