Bug 227724 - _WKWebAuthenticationPanel escapes slashes in origin
Summary: _WKWebAuthenticationPanel escapes slashes in origin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-06 15:04 PDT by Garrett Davidson
Modified: 2021-07-12 16:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.76 KB, patch)
2021-07-06 15:06 PDT, Garrett Davidson 		no flags Details | Formatted Diff | Diff
Patch (8.45 KB, patch)
2021-07-08 11:07 PDT, Garrett Davidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Garrett Davidson 2021-07-06 15:04:23 PDT 
_WKWebAuthenticationPanel escapes slashes in origin
Comment 1 Garrett Davidson 2021-07-06 15:06:13 PDT 
Created attachment 432979 [details]
Patch
Comment 2 Garrett Davidson 2021-07-06 15:06:17 PDT 
<rdar://problem/80232742>
Comment 3 Brent Fulgham 2021-07-06 15:35:11 PDT 
Comment on attachment 432979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432979&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:76
> +    return [NSJSONSerialization dataWithJSONObject:dictionary.get() options:(NSJSONWritingSortedKeys | NSJSONWritingWithoutEscapingSlashes) error:nil];

Seems like we should add a test of some kind to make sure we don't break this.

Could you add a TestWebKitAPI test to OpenSource/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm that confirms that the JSON blob is right?
Comment 4 Garrett Davidson 2021-07-08 11:07:30 PDT 
Created attachment 433143 [details]
Patch
Comment 5 Kate Cheney 2021-07-12 16:08:27 PDT 
Comment on attachment 433143 [details]
Patch

r=me
Comment 6 EWS 2021-07-12 16:43:23 PDT 
Committed r279856 (239610@main): <https://commits.webkit.org/239610@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433143 [details].