| Summary: | Fix type error in testb3 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yijia Huang <yijia_huang> | ||||||
| Component: | JavaScriptCore | Assignee: | Yijia Huang <yijia_huang> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, yijia_huang | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Yijia Huang
2021-07-06 14:30:47 PDT
Created attachment 432976 [details]
Patch
Comment on attachment 432976 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432976&action=review > Source/JavaScriptCore/b3/testb3_3.cpp:93 > Value* lsbValue = root->appendNew<Const32Value>(proc, Origin(), lsb); > - Value* amountValue = root->appendNew<Const64Value>(proc, Origin(), amount); > + Value* amountValue = root->appendNew<Const32Value>(proc, Origin(), amount); Why pass lab and amount in as int64_t then? Ditto for lsbs and widths vectors, why Vector<int64_t>? (In reply to Mark Lam from comment #2) > Comment on attachment 432976 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=432976&action=review > > > Source/JavaScriptCore/b3/testb3_3.cpp:93 > > Value* lsbValue = root->appendNew<Const32Value>(proc, Origin(), lsb); > > - Value* amountValue = root->appendNew<Const64Value>(proc, Origin(), amount); > > + Value* amountValue = root->appendNew<Const32Value>(proc, Origin(), amount); > > Why pass lab and amount in as int64_t then? Ditto for lsbs and widths > vectors, why Vector<int64_t>? Can you fix these as well? Created attachment 432980 [details]
Patch
Committed r279627 (239445@main): <https://commits.webkit.org/239445@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432980 [details]. |