Summary: | [Cairo] Merge PlatformContextCairo into GraphicsContextCairo | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||||||
Component: | Platform | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | annulen, cgarcia, dino, don.olmstead, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, mmaxfield, philipj, ryuan.choi, sergio, thorton, webkit-bug-importer, zdobersek | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Fujii Hironori
2021-07-06 14:30:03 PDT
Created attachment 432972 [details]
WIP patch
Created attachment 432973 [details]
WIP patch
Created attachment 432975 [details]
WIP patch
EWS style checker failed.
> ERROR: Source/WebCore/platform/graphics/cairo/GraphicsContextGLCairo.cpp:34: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
check-webkit-style considers "GraphicsContext.h" is the primary header for GraphicsContextGLCairo.cpp.
I think GraphicsContextGLCairo.cpp should be renamed to GraphicsContextGLOpenGLCairo.cpp to make "GraphicsContextGLOpenGL.h" the primary header.
Created attachment 432992 [details]
Patch
Comment on attachment 432992 [details]
Patch
r=me
Comment on attachment 432992 [details] Patch Clearing flags on attachment: 432992 Committed r279658 (239471@main): <https://commits.webkit.org/239471@main> All reviewed patches have been landed. Closing bug. This change causes new test crashes. Filed: Bug 227827 – [WinCairo] drag tests are crashing after r279658 Nice, thank you for doing some follow-through on the refactor! This is great :) |