Bug 227721

Summary:

[Cairo] Merge PlatformContextCairo into GraphicsContextCairo

Product:

WebKit

Reporter:

Fujii Hironori <fujii.hironori>

Component:

Platform

Assignee:

Fujii Hironori <fujii.hironori>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, cgarcia, dino, don.olmstead, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, jer.noble, kondapallykalyan, mmaxfield, philipj, ryuan.choi, sergio, thorton, webkit-bug-importer, zdobersek

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
WIP patch	none
WIP patch	ews-feeder: commit-queue-
WIP patch	none
Patch	none

Fujii Hironori

Reported 2021-07-06 14:30:03 PDT

[Cairo] Merge PlatformContextCairo into GraphicsContextCairo PlatformContextCairo was originally introduced to separate Cairo specific code from the platform-independent GraphicsContext. However, GraphicsContext is a virtual class nowadays. And, GraphicsContextCairo is a Cairo specifix concrete class.

Attachments
WIP patch (547 bytes, patch) 2021-07-06 14:31 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
WIP patch (75.07 KB, patch) 2021-07-06 14:31 PDT, Fujii Hironori	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP patch (75.21 KB, patch) 2021-07-06 14:44 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Patch (85.56 KB, patch) 2021-07-06 17:30 PDT, Fujii Hironori	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Fujii Hironori

Comment 1 2021-07-06 14:31:13 PDT

Created attachment 432972 [details] WIP patch

Fujii Hironori

Comment 2 2021-07-06 14:31:51 PDT

Created attachment 432973 [details] WIP patch

Fujii Hironori

Comment 3 2021-07-06 14:44:53 PDT

Created attachment 432975 [details] WIP patch

Fujii Hironori

Comment 4 2021-07-06 17:20:04 PDT

EWS style checker failed. > ERROR: Source/WebCore/platform/graphics/cairo/GraphicsContextGLCairo.cpp:34: Found header this file implements after other header. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] check-webkit-style considers "GraphicsContext.h" is the primary header for GraphicsContextGLCairo.cpp. I think GraphicsContextGLCairo.cpp should be renamed to GraphicsContextGLOpenGLCairo.cpp to make "GraphicsContextGLOpenGL.h" the primary header.

Fujii Hironori

Comment 5 2021-07-06 17:30:57 PDT

Created attachment 432992 [details] Patch

Don Olmstead

Comment 6 2021-07-07 11:09:24 PDT

Comment on attachment 432992 [details] Patch r=me

Fujii Hironori

Comment 7 2021-07-07 12:44:06 PDT

Comment on attachment 432992 [details] Patch Clearing flags on attachment: 432992 Committed r279658 (239471@main): <https://commits.webkit.org/239471@main>

Fujii Hironori

Comment 8 2021-07-07 12:44:10 PDT

All reviewed patches have been landed. Closing bug.