Summary: | [OpenSSL] Implement CryptoAlgorithmEC* | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yoshiaki Jitsukawa <yoshiaki.jitsukawa> | ||||||
Component: | Platform | Assignee: | Yoshiaki Jitsukawa <yoshiaki.jitsukawa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | don.olmstead, ews-watchlist, jiewen_tan, stephan.szabo, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 206439 | ||||||||
Attachments: |
|
Description
Yoshiaki Jitsukawa
2021-07-03 00:53:58 PDT
Created attachment 432919 [details]
Patch
Comment on attachment 432919 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432919&action=review > Source/WebCore/crypto/openssl/CryptoKeyECOpenSSL.cpp:272 > + return false; This seems like it should be a return nullptr; Appears to cause a failure for me on playstation complaining about no viable conversion from returned value of type 'bool' to function return type 'RefPtr<WebCore::CryptoKeyEC>. Created attachment 432990 [details]
Patch
> This seems like it should be a return nullptr;
Thanks, I fixed it with the new patch along with warning fixes of ptrdiff vs size_t comparison in CryptoKeyEC::platformImportSpki/Pkcs8().
Committed r279682 (239487@main): <https://commits.webkit.org/239487@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432990 [details]. |