Bug 227600

Summary:

[run-webkit-tests] Set software_variant from runtime

Product:

WebKit

Reporter:

Jonathan Bedard <jbedard>

Component:

Tools / Tests

Assignee:

Jonathan Bedard <jbedard>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, glenn, slewis, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Jonathan Bedard 2021-07-01 16:20:57 PDT

We currently try to infer the software_variant from the runtime. This is not really correct, the software_variant should be derived from the runtime. This is particularly relevant for iPhone and iPad where two device_families share a software_variant.

Comment 1 Jonathan Bedard 2021-07-01 16:23:32 PDT

<rdar://problem/80052263>

Comment 2 Jonathan Bedard 2021-07-01 16:27:22 PDT

Created attachment 432743 [details]
Patch

Comment 3 EWS 2021-07-01 21:05:49 PDT

Committed r279496 (239348@main): <https://commits.webkit.org/239348@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432743 [details].