Bug 227591

Summary: Add logging for legacy AppHighlight decoding to aid in future debugging.
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch wenson_hsieh: review+

Megan Gardner
Reported 2021-07-01 12:50:38 PDT
Add logging for legacy AppHighlight decoding to aid in future debugging.
Attachments
Patch (2.07 KB, patch)
2021-07-01 12:54 PDT, Megan Gardner 		no flags
DetailsFormatted DiffDiff
Patch (3.85 KB, patch)
2021-07-08 09:16 PDT, Megan Gardner 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Megan Gardner
Comment 1 2021-07-01 12:54:20 PDT
Created attachment 432717 [details] Patch
Tim Horton
Comment 2 2021-07-01 12:57:30 PDT
Comment on attachment 432717 [details] Patch You should probably also think about other logs that might be useful (AppHighlightRangeData failed to decode?) to diagnose issues from the field.
Megan Gardner
Comment 3 2021-07-08 09:16:53 PDT
Created attachment 433136 [details] Patch
Wenson Hsieh
Comment 4 2021-07-08 09:32:20 PDT
Comment on attachment 433136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433136&action=review > Source/WebCore/Modules/highlight/AppHighlightStorage.cpp:136 > + RELEASE_LOG(AppHighlights, "Attempting fallback text search for AppHighlightRangeData."); Do you need to `#include Logging.h` in this file as well? (I suspect it's currently grabbing it from the AppHighlightRangeData.cpp here, since it's right before this file in unified sources).
EWS
Comment 5 2021-07-08 10:17:18 PDT
Committed r279728 (239515@main): <https://commits.webkit.org/239515@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432717 [details].
Radar WebKit Bug Importer
Comment 6 2021-07-08 10:18:16 PDT
<rdar://problem/80330605>
Note You need to log in before you can comment on or make changes to this bug.