| Summary: | Add logging for legacy AppHighlight decoding to aid in future debugging. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||||
| Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | thorton, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Megan Gardner
2021-07-01 12:50:38 PDT
Created attachment 432717 [details]
Patch
Comment on attachment 432717 [details]
Patch
You should probably also think about other logs that might be useful (AppHighlightRangeData failed to decode?) to diagnose issues from the field.
Created attachment 433136 [details]
Patch
Comment on attachment 433136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433136&action=review > Source/WebCore/Modules/highlight/AppHighlightStorage.cpp:136 > + RELEASE_LOG(AppHighlights, "Attempting fallback text search for AppHighlightRangeData."); Do you need to `#include Logging.h` in this file as well? (I suspect it's currently grabbing it from the AppHighlightRangeData.cpp here, since it's right before this file in unified sources). Committed r279728 (239515@main): <https://commits.webkit.org/239515@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432717 [details]. |