Bug 227591 - Add logging for legacy AppHighlight decoding to aid in future debugging.
Summary: Add logging for legacy AppHighlight decoding to aid in future debugging.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Megan Gardner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-01 12:50 PDT by Megan Gardner
Modified: 2021-07-08 10:18 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.07 KB, patch)
2021-07-01 12:54 PDT, Megan Gardner 		no flags Details | Formatted Diff | Diff
Patch (3.85 KB, patch)
2021-07-08 09:16 PDT, Megan Gardner 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Megan Gardner 2021-07-01 12:50:38 PDT 
Add logging for legacy AppHighlight decoding to aid in future debugging.
Comment 1 Megan Gardner 2021-07-01 12:54:20 PDT 
Created attachment 432717 [details]
Patch
Comment 2 Tim Horton 2021-07-01 12:57:30 PDT 
Comment on attachment 432717 [details]
Patch

You should probably also think about other logs that might be useful (AppHighlightRangeData failed to decode?) to diagnose issues from the field.
Comment 3 Megan Gardner 2021-07-08 09:16:53 PDT 
Created attachment 433136 [details]
Patch
Comment 4 Wenson Hsieh 2021-07-08 09:32:20 PDT 
Comment on attachment 433136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433136&action=review

> Source/WebCore/Modules/highlight/AppHighlightStorage.cpp:136
> +    RELEASE_LOG(AppHighlights, "Attempting fallback text search for AppHighlightRangeData.");

Do you need to `#include Logging.h` in this file as well?

(I suspect it's currently grabbing it from the AppHighlightRangeData.cpp here, since it's right before this file in unified sources).
Comment 5 EWS 2021-07-08 10:17:18 PDT 
Committed r279728 (239515@main): <https://commits.webkit.org/239515@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432717 [details].
Comment 6 Radar WebKit Bug Importer 2021-07-08 10:18:16 PDT 
<rdar://problem/80330605>