Bug 227582

Summary: WebGL video to texture upload spends time clearing the uploaded-to texture
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 227585    
Attachments:
Description Flags
Patch kbr: review+

Description Kimmo Kinnunen 2021-07-01 06:04:24 PDT 
WebGL video to texture upload spends time clearing the uploaded-to texture
Comment 1 Radar WebKit Bug Importer 2021-07-01 06:04:46 PDT 
<rdar://problem/80020335>
Comment 2 Kimmo Kinnunen 2021-07-01 06:40:06 PDT 
Visible for content where big textures (4k, for example) are used.

https://www.youtube.com/watch?v=HKNI658SKJ4
Comment 3 Kimmo Kinnunen 2021-07-01 08:04:13 PDT 
Created attachment 432690 [details]
Patch
Comment 4 Kenneth Russell 2021-07-01 18:25:40 PDT 
Comment on attachment 432690 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432690&action=review

Very nice investigation and work. r+ with one small comment.

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:271
> +        // WebGL requires that all resources are cleared at creation.

Could you add a comment here that performing robust resource initialization in the VideoTextureCopier adds a large amount of overhead?
Comment 5 Dean Jackson 2021-07-06 15:34:16 PDT 
Committed r279624 (239442@main): <https://commits.webkit.org/239442@main>