Bug 227581

Summary: [Model] Restrict IPC calls to ARKit SPI availability and runtime flag
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, japhet, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch thorton: review+

Antoine Quint
Reported 2021-07-01 05:39:24 PDT
[Model] Restrict IPC calls to ARKit SPI availability and runtime flag
Attachments
Patch (29.82 KB, patch)
2021-07-01 05:42 PDT, Antoine Quint 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (34.11 KB, patch)
2021-07-01 06:52 PDT, Antoine Quint 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2021-07-01 05:42:28 PDT
Created attachment 432682 [details] Patch
Antoine Quint
Comment 2 2021-07-01 06:52:39 PDT
Created attachment 432686 [details] Patch
Tim Horton
Comment 3 2021-07-01 12:31:09 PDT
Comment on attachment 432686 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432686&action=review > Source/WebKit/UIProcess/Cocoa/ModelElementControllerCocoa.mm:59 > + if (!m_webPageProxy->preferences().modelElementEnabled()) > + return; These could be stronger (like MESSAGE_CHECKs, killing the WP if something unexpected is happening), but this is certainly better than nothing.
Antoine Quint
Comment 4 2021-07-01 12:37:27 PDT
Committed r279477 (239330@main): <https://commits.webkit.org/239330@main>
Radar WebKit Bug Importer
Comment 5 2021-07-01 12:38:19 PDT
<rdar://problem/80040015>
Note You need to log in before you can comment on or make changes to this bug.