Bug 227572

Summary: [macOS] Fix sandbox violations related to IOKit filtering
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+, bfulgham: commit-queue-
Patch none

Per Arne Vollan
Reported 2021-07-01 00:26:39 PDT
The IOKit filter on macOS is missing some methods which are being used.
Attachments
Patch (1.47 KB, patch)
2021-07-01 00:29 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (1.76 KB, patch)
2021-07-01 05:40 PDT, Per Arne Vollan 		bfulgham: review+
bfulgham: commit-queue-
DetailsFormatted DiffDiff
Patch (1.75 KB, patch)
2021-07-01 10:56 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-07-01 00:27:06 PDT
<rdar://78354215>
Per Arne Vollan
Comment 2 2021-07-01 00:29:45 PDT
Created attachment 432662 [details] Patch
Per Arne Vollan
Comment 3 2021-07-01 05:40:32 PDT
Created attachment 432681 [details] Patch
Brent Fulgham
Comment 4 2021-07-01 09:39:19 PDT
Comment on attachment 432681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432681&action=review > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:122 > +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000 && __MAC_OS_X_VERSION_MIN_REQUIRED < 120500 Should this be 130000? I don't think we typically build with MIN_REQUIRED not being a full round number.
Brent Fulgham
Comment 5 2021-07-01 10:34:18 PDT
Comment on attachment 432681 [details] Patch Per Arne and I spoke, and he will land the patch with the 130000 round number. r=me
Per Arne Vollan
Comment 6 2021-07-01 10:56:01 PDT
Created attachment 432708 [details] Patch
Per Arne Vollan
Comment 7 2021-07-01 10:56:49 PDT
Comment on attachment 432708 [details] Patch Thanks for reviewing!
EWS
Comment 8 2021-07-01 11:52:11 PDT
Committed r279476 (239329@main): <https://commits.webkit.org/239329@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432708 [details].
Note You need to log in before you can comment on or make changes to this bug.