Bug 227572 - [macOS] Fix sandbox violations related to IOKit filtering
Summary: [macOS] Fix sandbox violations related to IOKit filtering
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-07-01 00:26 PDT by Per Arne Vollan
Modified: 2021-07-01 11:52 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.47 KB, patch)
2021-07-01 00:29 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (1.76 KB, patch)
2021-07-01 05:40 PDT, Per Arne Vollan 		bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff
Patch (1.75 KB, patch)
2021-07-01 10:56 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-07-01 00:26:39 PDT 
The IOKit filter on macOS is missing some methods which are being used.
Comment 1 Per Arne Vollan 2021-07-01 00:27:06 PDT 
<rdar://78354215>
Comment 2 Per Arne Vollan 2021-07-01 00:29:45 PDT 
Created attachment 432662 [details]
Patch
Comment 3 Per Arne Vollan 2021-07-01 05:40:32 PDT 
Created attachment 432681 [details]
Patch
Comment 4 Brent Fulgham 2021-07-01 09:39:19 PDT 
Comment on attachment 432681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432681&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:122
> +#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000 && __MAC_OS_X_VERSION_MIN_REQUIRED < 120500

Should this be 130000? I don't think we typically build with MIN_REQUIRED not being a full round number.
Comment 5 Brent Fulgham 2021-07-01 10:34:18 PDT 
Comment on attachment 432681 [details]
Patch

Per Arne and I spoke, and he will land the patch with the 130000 round number. r=me
Comment 6 Per Arne Vollan 2021-07-01 10:56:01 PDT 
Created attachment 432708 [details]
Patch
Comment 7 Per Arne Vollan 2021-07-01 10:56:49 PDT 
Comment on attachment 432708 [details]
Patch

Thanks for reviewing!
Comment 8 EWS 2021-07-01 11:52:11 PDT 
Committed r279476 (239329@main): <https://commits.webkit.org/239329@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432708 [details].