Bug 227558

Summary: BytecodeGenerator should emit is_null in more places
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED INVALID    
Severity: Normal CC: ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Keith Miller
Reported 2021-06-30 18:07:55 PDT
BytecodeGenerator should emit is_null and is_undefined in more places
Attachments
Patch (1.95 KB, patch)
2021-06-30 18:20 PDT, Keith Miller
ews-feeder: commit-queue-
Keith Miller
Comment 1 2021-06-30 18:20:57 PDT
Yusuke Suzuki
Comment 2 2021-06-30 18:23:50 PDT
Comment on attachment 432648 [details] Patch I think this is intentional: OpEqNull also checks masquerade-as-undefined while strict-eq-jsnull doesn't.
Keith Miller
Comment 3 2021-06-30 18:28:05 PDT
(In reply to Yusuke Suzuki from comment #2) > Comment on attachment 432648 [details] > Patch > > I think this is intentional: OpEqNull also checks masquerade-as-undefined > while strict-eq-jsnull doesn't. Ah, I'm surprised we don't have a test for this...
Mark Lam
Comment 4 2021-06-30 21:19:31 PDT
(In reply to Keith Miller from comment #3) > (In reply to Yusuke Suzuki from comment #2) > > Comment on attachment 432648 [details] > > Patch > > > > I think this is intentional: OpEqNull also checks masquerade-as-undefined > > while strict-eq-jsnull doesn't. > > Ah, I'm surprised we don't have a test for this... Do we have one in testapi?
Radar WebKit Bug Importer
Comment 5 2021-07-07 18:08:20 PDT
Note You need to log in before you can comment on or make changes to this bug.