Bug 227558

Summary: BytecodeGenerator should emit is_null in more places
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED INVALID    
Severity: Normal CC: ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ews-feeder: commit-queue-

Description Keith Miller 2021-06-30 18:07:55 PDT 
BytecodeGenerator should emit is_null and is_undefined in more places
Comment 1 Keith Miller 2021-06-30 18:20:57 PDT 
Created attachment 432648 [details]
Patch
Comment 2 Yusuke Suzuki 2021-06-30 18:23:50 PDT 
Comment on attachment 432648 [details]
Patch

I think this is intentional: OpEqNull also checks masquerade-as-undefined while strict-eq-jsnull doesn't.
Comment 3 Keith Miller 2021-06-30 18:28:05 PDT 
(In reply to Yusuke Suzuki from comment #2)
> Comment on attachment 432648 [details]
> Patch
> 
> I think this is intentional: OpEqNull also checks masquerade-as-undefined
> while strict-eq-jsnull doesn't.

Ah, I'm surprised we don't have a test for this...
Comment 4 Mark Lam 2021-06-30 21:19:31 PDT 
(In reply to Keith Miller from comment #3)
> (In reply to Yusuke Suzuki from comment #2)
> > Comment on attachment 432648 [details]
> > Patch
> > 
> > I think this is intentional: OpEqNull also checks masquerade-as-undefined
> > while strict-eq-jsnull doesn't.
> 
> Ah, I'm surprised we don't have a test for this...

Do we have one in testapi?
Comment 5 Radar WebKit Bug Importer 2021-07-07 18:08:20 PDT 
<rdar://problem/80298794>