Bug 227556

Summary: PCM: Change import from CryptoKitCBridging to CryptoKitPrivate
Product: WebKit Reporter: John Wilander <wilander>
Component: WebCore Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, amir_mark, annulen, cdumez, ews-watchlist, gyuyoung.kim, japhet, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

John Wilander
Reported 2021-06-30 16:49:24 PDT
We should change PCM's import from CryptoKitCBridging to CryptoKitPrivate.
Attachments
Patch (24.88 KB, patch)
2021-06-30 17:00 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch (25.06 KB, patch)
2021-07-01 15:14 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-06-30 16:49:53 PDT
<rdar://problem/79992592>
John Wilander
Comment 2 2021-06-30 17:00:24 PDT
Created attachment 432646 [details] Patch
Alex Christensen
Comment 3 2021-06-30 17:07:44 PDT
Comment on attachment 432646 [details] Patch Rename as suggested by rdar://79923598
Alex Christensen
Comment 4 2021-06-30 17:09:17 PDT
Comment on attachment 432646 [details] Patch Rename as suggested by rdar://79923598 Sure.
John Wilander
Comment 5 2021-06-30 22:55:06 PDT
win bot issue is unrelated.
John Wilander
Comment 6 2021-06-30 22:55:26 PDT
Comment on attachment 432646 [details] Patch Thanks for the review, Alex!
EWS
Comment 7 2021-06-30 23:32:47 PDT
Committed r279452 (239308@main): <https://commits.webkit.org/239308@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432646 [details].
Amir Mark Jr
Comment 8 2021-07-01 10:08:36 PDT
Reverted r279452 for reason: Broke MacOS build Committed r279467 (239323@main): <https://commits.webkit.org/239323@main>
John Wilander
Comment 9 2021-07-01 15:14:53 PDT
Created attachment 432730 [details] Patch
John Wilander
Comment 10 2021-07-01 16:15:21 PDT
Comment on attachment 432730 [details] Patch The orange bubbles are due to a known issue with Python command time outs. Thanks again, Alex.
EWS
Comment 11 2021-07-01 18:08:01 PDT
Committed r279491 (239343@main): <https://commits.webkit.org/239343@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432730 [details].
Note You need to log in before you can comment on or make changes to this bug.