| Summary: | move some Mac MathML test expectation files around again | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Cameron McCormack (:heycam) <heycam> | ||||||
| Component: | Tools / Tests | Assignee: | Cameron McCormack (:heycam) <heycam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | dbarton, ews-watchlist, fred.wang, tsavell, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Local Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Cameron McCormack (:heycam)
2021-06-29 23:39:00 PDT
Created attachment 432569 [details]
Patch
Basically mac-catalina-{wk1,wk2} and mac-mojave-wk1 use one expectation file, and everything else on Mac uses another. For most of the tests here, the "everything else" was already the generic expectations file, but a couple had something else as the generic file, so for those I added new files under platform/mac/ to capture them rather than try to work out what other platforms needed their expectation files moved around to accommodate.
Committed r279485 (239337@main): <https://commits.webkit.org/239337@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432569 [details]. It looks like the expectation changes in https://trac.webkit.org/changeset/279485/webkit broke 7 mathML tests on Big Sur tracking in https://bugs.webkit.org/show_bug.cgi?id=227520 (In reply to Truitt Savell from comment #5) > It looks like the expectation changes in > https://trac.webkit.org/changeset/279485/webkit > > broke 7 mathML tests on Big Sur > > tracking in https://bugs.webkit.org/show_bug.cgi?id=227634 Corrected bug URL Reverted r279485 for reason: Broke expectations for 7 mathML test on Big Sur wk1 Committed r279511 (239363@main): <https://commits.webkit.org/239363@main> Created attachment 432870 [details]
Patch
(In reply to Truitt Savell from comment #7) > Broke expectations for 7 mathML test on Big Sur wk1 Forgot to remove the platform/mac-wk1/ files in the earlier patch, which caused those failures. Fingers crossed this new patch works everywhere. I've tested locally on {Monterey,BigSur} x {WK2,WK1}. Also just realized we no longer test on Mojave so removed those files. *** Bug 201680 has been marked as a duplicate of this bug. *** Committed r279570 (239401@main): <https://commits.webkit.org/239401@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432870 [details]. |