Bug 227508

Summary: Remove unnecessary canBeInternal invocations to mitigate the cost of potential unmatched patterns in B3LowerToAir
Product: WebKit Reporter: Yijia Huang <yijia_huang>
Component: JavaScriptCoreAssignee: Yijia Huang <yijia_huang>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yijia Huang
Reported 2021-06-29 15:10:54 PDT
...
Attachments
Patch (8.93 KB, patch)
2021-07-01 08:54 PDT, Yijia Huang 		no flags
DetailsFormatted DiffDiff
Patch (8.93 KB, patch)
2021-07-01 09:07 PDT, Yijia Huang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yijia Huang
Comment 1 2021-07-01 08:54:20 PDT
Created attachment 432701 [details] Patch
Keith Miller
Comment 2 2021-07-01 09:02:55 PDT
Comment on attachment 432701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432701&action=review > Source/JavaScriptCore/ChangeLog:10 > + The bit pattern doesn't cause the worst code generation in the all-internals-are-captured > + case. So, they don't need canBeInternal checks which might terminate potential matched > + scenarios. Nit: doesn't cause the worst => doesn't cause worse.
Yijia Huang
Comment 3 2021-07-01 09:07:19 PDT
Created attachment 432703 [details] Patch
EWS
Comment 4 2021-07-01 11:24:17 PDT
Committed r279473 (239327@main): <https://commits.webkit.org/239327@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432703 [details].
Radar WebKit Bug Importer
Comment 5 2021-07-01 11:25:31 PDT
<rdar://problem/80035749>
Note You need to log in before you can comment on or make changes to this bug.