| Summary: | Remove unnecessary canBeInternal invocations to mitigate the cost of potential unmatched patterns in B3LowerToAir | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yijia Huang <yijia_huang> | ||||||
| Component: | JavaScriptCore | Assignee: | Yijia Huang <yijia_huang> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, fpizlo, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Yijia Huang
2021-06-29 15:10:54 PDT
Created attachment 432701 [details]
Patch
Comment on attachment 432701 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432701&action=review > Source/JavaScriptCore/ChangeLog:10 > + The bit pattern doesn't cause the worst code generation in the all-internals-are-captured > + case. So, they don't need canBeInternal checks which might terminate potential matched > + scenarios. Nit: doesn't cause the worst => doesn't cause worse. Created attachment 432703 [details]
Patch
Committed r279473 (239327@main): <https://commits.webkit.org/239327@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432703 [details]. |