| Summary: | ASSERT in webgl/1.0.x/conformance/glsl/misc/uninitialized-local-global-variables.html IdGen ASSERT(*base != '_'); | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kimmo Kinnunen <kkinnunen> | ||||||||
| Component: | ANGLE | Assignee: | Kimmo Kinnunen <kkinnunen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, kpiddington, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Local Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=223923 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Kimmo Kinnunen
2021-06-29 03:40:46 PDT
Created attachment 432469 [details]
Patch
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE Created attachment 432470 [details]
Patch
Created attachment 432471 [details]
Patch
Comment on attachment 432471 [details] Patch OK since this is tested, but: please keep in mind that in the WebGL shading language spec certain prefixes are reserved. See https://www.khronos.org/registry/webgl/specs/latest/1.0/#4.3 . Plausibly, if the shader compiler was instantiated for a WebGL context, it should be using "_webgl" as the prefix for all of these internally-generated names. r+ Committed r279426 (239287@main): <https://commits.webkit.org/239287@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432471 [details]. |