Bug 227482 - ASSERT in webgl/1.0.x/conformance/glsl/misc/uninitialized-local-global-variables.html IdGen ASSERT(*base != '_');
Summary: ASSERT in webgl/1.0.x/conformance/glsl/misc/uninitialized-local-global-varia...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-29 03:40 PDT by Kimmo Kinnunen
Modified: 2021-06-30 11:34 PDT (History)
7 users (show)

See Also:


Attachments
Patch (6.70 KB, patch)
2021-06-29 04:16 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (6.67 KB, patch)
2021-06-29 04:21 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (6.67 KB, patch)
2021-06-29 05:01 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-06-29 03:40:46 PDT
ASSERT in  webgl/1.0.x/conformance/glsl/misc/uninitialized-local-global-variables.html   IdGen ASSERT(*base != '_');
Comment 1 Kimmo Kinnunen 2021-06-29 04:16:20 PDT
Created attachment 432469 [details]
Patch
Comment 2 EWS Watchlist 2021-06-29 04:17:16 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kimmo Kinnunen 2021-06-29 04:21:02 PDT
Created attachment 432470 [details]
Patch
Comment 4 Kimmo Kinnunen 2021-06-29 05:01:05 PDT
Created attachment 432471 [details]
Patch
Comment 5 Kenneth Russell 2021-06-29 15:46:35 PDT
Comment on attachment 432471 [details]
Patch

OK since this is tested, but: please keep in mind that in the WebGL shading language spec certain prefixes are reserved. See https://www.khronos.org/registry/webgl/specs/latest/1.0/#4.3 . Plausibly, if the shader compiler was instantiated for a WebGL context, it should be using "_webgl" as the prefix for all of these internally-generated names.

r+
Comment 6 EWS 2021-06-30 11:33:45 PDT
Committed r279426 (239287@main): <https://commits.webkit.org/239287@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432471 [details].
Comment 7 Radar WebKit Bug Importer 2021-06-30 11:34:42 PDT
<rdar://problem/79977324>