Bug 227462

Summary:

Nullptr crash in ResourceLoadStatisticsDatabaseStore::allAttributedPrivateClickMeasurement

Product:

WebKit

Reporter:

Sihui Liu <sihui_liu>

Component:

New Bugs

Assignee:

Sihui Liu <sihui_liu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Sihui Liu 2021-06-28 14:53:52 PDT

...

Comment 1 Sihui Liu 2021-06-28 14:54:25 PDT

rdar://50772934

Comment 2 Sihui Liu 2021-06-28 14:59:48 PDT

Created attachment 432427 [details]
Patch

Comment 3 Chris Dumez 2021-06-28 15:01:55 PDT

Comment on attachment 432427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432427&action=review

> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:3509
> +        return attributions;

Darin told me in the past to return { }; in such cases and not move the variable declaration so I am passing along the comment :)

Comment 4 Sihui Liu 2021-06-28 15:19:20 PDT

Created attachment 432430 [details]
Patch for landing

Comment 5 EWS 2021-06-28 17:21:58 PDT

Committed r279353 (239221@main): <https://commits.webkit.org/239221@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432430 [details].