Bug 227453

Summary: Live Text selections inside images is misaligned when "object-fit" is not "fill"
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, cdumez, changseok, esprehn+autocc, ews-watchlist, gyuyoung.kim, hi, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
thorton: review+
Patch for landing none

Wenson Hsieh
Reported 2021-06-28 09:40:55 PDT
On a Mac that supports live text: 1. Go to https://whsieh.github.io/examples/live-text 2. Try to select text in the images after the first
Attachments
Patch (19.56 KB, patch)
2021-06-28 10:06 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (20.54 KB, patch)
2021-06-28 12:35 PDT, Wenson Hsieh 		thorton: review+
DetailsFormatted DiffDiff
Patch for landing (20.54 KB, patch)
2021-06-28 14:02 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-06-28 10:06:53 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2021-06-28 12:35:10 PDT
Created attachment 432414 [details] Patch
Tim Horton
Comment 3 2021-06-28 13:10:25 PDT
Comment on attachment 432414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432414&action=review > Source/WebCore/html/HTMLElement.cpp:1466 > + document().updateLayoutIfDimensionsOutOfDate(*this); I don't think this is the right kind of layout? I think you want the normal update-if-needed-recursively
Wenson Hsieh
Comment 4 2021-06-28 13:22:39 PDT
Comment on attachment 432414 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432414&action=review >> Source/WebCore/html/HTMLElement.cpp:1466 >> + document().updateLayoutIfDimensionsOutOfDate(*this); > > I don't think this is the right kind of layout? I think you want the normal update-if-needed-recursively Good point — will change this to just be a standard `document().updateLayoutIgnorePendingStylesheets();`.
Wenson Hsieh
Comment 5 2021-06-28 14:02:41 PDT
Created attachment 432419 [details] Patch for landing
EWS
Comment 6 2021-06-28 14:44:59 PDT
Committed r279349 (239217@main): <https://commits.webkit.org/239217@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432419 [details].
Radar WebKit Bug Importer
Comment 7 2021-06-28 14:45:17 PDT
<rdar://problem/79882889>
Note You need to log in before you can comment on or make changes to this bug.