Bug 227451

Summary: ANGLE Metal index buffer restart range cache is could be maintained more consistently
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: ANGLEAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, ews-watchlist, kbr, kkinnunen, kondapallykalyan, kpiddington, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 227371    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Kimmo Kinnunen 2021-06-28 08:03:19 PDT 
ANGLE Metal index buffer left mapped when building primitive restart ranges

- When other cache buffers are marked dirty, the cache is cleared. When other cache buffers are detached, the cache is not cleared.
- When buffer is interpreted differently, the cache is not cleared.
Comment 1 Kimmo Kinnunen 2021-06-29 06:55:08 PDT 
Created attachment 432477 [details]
Patch
Comment 2 EWS Watchlist 2021-06-29 06:56:17 PDT 
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kenneth Russell 2021-06-29 16:03:24 PDT 
Comment on attachment 432477 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432477&action=review

Looks good to me. r+

> Source/ThirdParty/ANGLE/ChangeLog:3
> +        ANGLE Metal index buffer restart range cache is could be maintained more consistently

"is could" -> "could" (bug description should be updated too)
Comment 4 Radar WebKit Bug Importer 2021-07-05 08:04:16 PDT 
<rdar://problem/80177894>
Comment 5 EWS 2021-08-25 00:42:43 PDT 
Committed r281550 (240917@main): <https://commits.webkit.org/240917@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432477 [details].