| Summary: | RealtimeIncomingAudioSourceCocoa should support other sample rate than 48000 | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
youenn fablet
2021-06-28 02:38:04 PDT
Created attachment 432376 [details]
Patch
Created attachment 432382 [details]
Patch
Comment on attachment 432382 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432382&action=review > Source/WebCore/ChangeLog:8 > + We reduced memory allocations by early allocating buffers for the most often used sample rate (48000), but this broken other sample rates, like for G722. s/this broken/this broke/ Created attachment 432456 [details]
Patch for landing
Eric Carlsom found in /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Created attachment 432576 [details]
Patch for landing
Created attachment 432663 [details]
Patch for landing
Created attachment 432668 [details]
Patch for landing
Committed r279459 (239315@main): <https://commits.webkit.org/239315@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432668 [details]. |