Bug 227412

Summary: [iOS] Web process sometimes crashes under findDataDetectionResultElementInImageOverlay
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: PlatformAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, hi, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fix typo none

Description Wenson Hsieh 2021-06-25 16:36:53 PDT
rdar://79588091
Comment 1 Wenson Hsieh 2021-06-25 16:44:56 PDT
Created attachment 432311 [details]
Patch
Comment 2 Devin Rousso 2021-06-25 16:47:07 PDT
Comment on attachment 432311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432311&action=review

rs=me

> Source/WebKit/ChangeLog:10
> +        shadow root of the element responding to click events), and that the element responding to click events contains

NIT: extra `)`
Comment 3 Wenson Hsieh 2021-06-25 16:47:52 PDT
(In reply to Devin Rousso from comment #2)
> Comment on attachment 432311 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=432311&action=review
> 
> rs=me
> 
> > Source/WebKit/ChangeLog:10
> > +        shadow root of the element responding to click events), and that the element responding to click events contains
> 
> NIT: extra `)`

Good catch!
Comment 4 Wenson Hsieh 2021-06-25 16:49:05 PDT
Created attachment 432312 [details]
Fix typo
Comment 5 EWS 2021-06-25 17:49:24 PDT
Committed r279304 (239180@main): <https://commits.webkit.org/239180@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432312 [details].