Bug 227412 - [iOS] Web process sometimes crashes under findDataDetectionResultElementInImageOverlay
Summary: [iOS] Web process sometimes crashes under findDataDetectionResultElementInIma...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-25 16:36 PDT by Wenson Hsieh
Modified: 2021-06-25 17:49 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.96 KB, patch)
2021-06-25 16:44 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix typo (1.96 KB, patch)
2021-06-25 16:49 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-06-25 16:36:53 PDT 
rdar://79588091
Comment 1 Wenson Hsieh 2021-06-25 16:44:56 PDT 
Created attachment 432311 [details]
Patch
Comment 2 Devin Rousso 2021-06-25 16:47:07 PDT 
Comment on attachment 432311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432311&action=review

rs=me

> Source/WebKit/ChangeLog:10
> +        shadow root of the element responding to click events), and that the element responding to click events contains

NIT: extra `)`
Comment 3 Wenson Hsieh 2021-06-25 16:47:52 PDT 
(In reply to Devin Rousso from comment #2)
> Comment on attachment 432311 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=432311&action=review
> 
> rs=me
> 
> > Source/WebKit/ChangeLog:10
> > +        shadow root of the element responding to click events), and that the element responding to click events contains
> 
> NIT: extra `)`

Good catch!
Comment 4 Wenson Hsieh 2021-06-25 16:49:05 PDT 
Created attachment 432312 [details]
Fix typo
Comment 5 EWS 2021-06-25 17:49:24 PDT 
Committed r279304 (239180@main): <https://commits.webkit.org/239180@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432312 [details].