Bug 227395

Summary: [css-flexbox] Improve computation of intrinsic sizes of flex items with aspect ratio
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: New BugsAssignee: Sergio Villar Senin <svillar>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, rbuis, svillar, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rbuis: review+

Description Sergio Villar Senin 2021-06-25 04:26:35 PDT
[css-flexbox] Improve computation of intrinsic sizes of flex items with aspect ratio
Comment 1 Sergio Villar Senin 2021-06-25 07:18:10 PDT
Created attachment 432267 [details]
Patch
Comment 2 Rob Buis 2021-06-25 07:40:47 PDT
Comment on attachment 432267 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432267&action=review

> Source/WebCore/ChangeLog:12
> +        sizes mentioned in the specs https://drafts.csswg.org/css-flexbox/#definite-sizes.

Would do "in the specs, see http:....", "in the specs (http:....)" or make a footnote [1].
Comment 3 Sergio Villar Senin 2021-06-25 08:42:18 PDT
Committed r279286 (239165@main): <https://commits.webkit.org/239165@main>
Comment 4 Radar WebKit Bug Importer 2021-06-25 08:43:16 PDT
<rdar://problem/79779996>