| Summary: | Fix null crash in AudioMediaStreamTrackRendererCocoa::start | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2021-06-24 23:33:11 PDT
Created attachment 432240 [details]
Patch
Comment on attachment 432240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432240&action=review > Source/WebCore/ChangeLog:11 > + has an early return or hasn't been called yet. It probably means we have an early return, which means we have an error case when creating the audio unit. Release logging would tell us what actually happened. Comment on attachment 432240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432240&action=review >> Source/WebCore/ChangeLog:11 >> + has an early return or hasn't been called yet. > > It probably means we have an early return, which means we have an error case when creating the audio unit. > Release logging would tell us what actually happened. There's already release logging in LocalAudioMediaStreamTrackRendererInternalUnit::retrieveFormatDescription Committed r279296 (239172@main): <https://commits.webkit.org/239172@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432240 [details]. |