Bug 227386

Summary: Fix null crash in AudioMediaStreamTrackRendererCocoa::start
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Alex Christensen
Reported 2021-06-24 23:33:11 PDT
Fix null crash in AudioMediaStreamTrackRendererCocoa::start
Attachments
Patch (2.00 KB, patch)
2021-06-24 23:37 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-06-24 23:37:13 PDT
Created attachment 432240 [details] Patch
Alex Christensen
Comment 2 2021-06-24 23:37:16 PDT
<rdar://problem/79045120>
youenn fablet
Comment 3 2021-06-25 05:06:48 PDT
Comment on attachment 432240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432240&action=review > Source/WebCore/ChangeLog:11 > + has an early return or hasn't been called yet. It probably means we have an early return, which means we have an error case when creating the audio unit. Release logging would tell us what actually happened.
Alex Christensen
Comment 4 2021-06-25 12:41:36 PDT
Comment on attachment 432240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432240&action=review >> Source/WebCore/ChangeLog:11 >> + has an early return or hasn't been called yet. > > It probably means we have an early return, which means we have an error case when creating the audio unit. > Release logging would tell us what actually happened. There's already release logging in LocalAudioMediaStreamTrackRendererInternalUnit::retrieveFormatDescription
EWS
Comment 5 2021-06-25 12:51:42 PDT
Committed r279296 (239172@main): <https://commits.webkit.org/239172@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432240 [details].
Note You need to log in before you can comment on or make changes to this bug.