Bug 227385

Summary:

[macOS] -[NSString _web_widthWithFont:] returns 0

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Test	none
Patch	none
Patch	none
Patch	none
Patch	simon.fraser: review+
Patch for committing	none
Patch for committing	none

Myles C. Maxfield

Reported 2021-06-24 23:04:38 PDT

[macOS] -[NSString _web_widthWithFont:] returns 0 for Thai text

Attachments
Test (6.50 KB, patch) 2021-06-24 23:05 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (8.57 KB, patch) 2021-06-24 23:39 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (8.56 KB, patch) 2021-06-24 23:40 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (9.92 KB, patch) 2021-06-25 12:23 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (9.93 KB, patch) 2021-06-25 16:01 PDT, Myles C. Maxfield	simon.fraser: review+	Details Formatted Diff Diff
Patch for committing (9.93 KB, patch) 2021-06-25 16:25 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch for committing (9.92 KB, patch) 2021-06-25 16:26 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2021-06-24 23:05:10 PDT

<rdar://problem/79430938>

Myles C. Maxfield

Comment 2 2021-06-24 23:05:46 PDT

Created attachment 432239 [details] Test

Myles C. Maxfield

Comment 3 2021-06-24 23:05:49 PDT

<rdar://problem/79430938>

Myles C. Maxfield

Comment 4 2021-06-24 23:39:33 PDT

Created attachment 432241 [details] Patch

Myles C. Maxfield

Comment 5 2021-06-24 23:40:38 PDT

Created attachment 432242 [details] Patch

Myles C. Maxfield

Comment 6 2021-06-25 12:23:50 PDT

Created attachment 432285 [details] Patch

Myles C. Maxfield

Comment 7 2021-06-25 16:01:22 PDT

Created attachment 432303 [details] Patch

Simon Fraser (smfr)

Comment 8 2021-06-25 16:20:05 PDT

Comment on attachment 432303 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432303&action=review > Tools/TestWebKitAPI/Tests/mac/StringWidth.mm:38 > + EXPECT_GE(result, 3); 3 seems a little small?

Myles C. Maxfield

Comment 9 2021-06-25 16:25:17 PDT

Created attachment 432308 [details] Patch for committing

Myles C. Maxfield

Comment 10 2021-06-25 16:26:49 PDT

Created attachment 432309 [details] Patch for committing

EWS

Comment 11 2021-06-25 17:09:24 PDT

Committed r279301 (239177@main): <https://commits.webkit.org/239177@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432309 [details].

Note You need to log in before you can comment on or make changes to this bug.