Bug 227385 - [macOS] -[NSString _web_widthWithFont:] returns 0
Summary: [macOS] -[NSString _web_widthWithFont:] returns 0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-06-24 23:04 PDT by Myles C. Maxfield
Modified: 2021-06-25 17:09 PDT (History)
2 users (show)

See Also:

Attachments
Test (6.50 KB, patch)
2021-06-24 23:05 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (8.57 KB, patch)
2021-06-24 23:39 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (8.56 KB, patch)
2021-06-24 23:40 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (9.92 KB, patch)
2021-06-25 12:23 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (9.93 KB, patch)
2021-06-25 16:01 PDT, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
Patch for committing (9.93 KB, patch)
2021-06-25 16:25 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (9.92 KB, patch)
2021-06-25 16:26 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-06-24 23:04:38 PDT 
[macOS] -[NSString _web_widthWithFont:] returns 0 for Thai text
Comment 1 Myles C. Maxfield 2021-06-24 23:05:10 PDT 
<rdar://problem/79430938>
Comment 2 Myles C. Maxfield 2021-06-24 23:05:46 PDT 
Created attachment 432239 [details]
Test
Comment 3 Myles C. Maxfield 2021-06-24 23:05:49 PDT 
<rdar://problem/79430938>
Comment 4 Myles C. Maxfield 2021-06-24 23:39:33 PDT 
Created attachment 432241 [details]
Patch
Comment 5 Myles C. Maxfield 2021-06-24 23:40:38 PDT 
Created attachment 432242 [details]
Patch
Comment 6 Myles C. Maxfield 2021-06-25 12:23:50 PDT 
Created attachment 432285 [details]
Patch
Comment 7 Myles C. Maxfield 2021-06-25 16:01:22 PDT 
Created attachment 432303 [details]
Patch
Comment 8 Simon Fraser (smfr) 2021-06-25 16:20:05 PDT 
Comment on attachment 432303 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432303&action=review

> Tools/TestWebKitAPI/Tests/mac/StringWidth.mm:38
> +    EXPECT_GE(result, 3);

3 seems a little small?
Comment 9 Myles C. Maxfield 2021-06-25 16:25:17 PDT 
Created attachment 432308 [details]
Patch for committing
Comment 10 Myles C. Maxfield 2021-06-25 16:26:49 PDT 
Created attachment 432309 [details]
Patch for committing
Comment 11 EWS 2021-06-25 17:09:24 PDT 
Committed r279301 (239177@main): <https://commits.webkit.org/239177@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432309 [details].