Bug 227362

Summary: [GStreamer] TextCombiner has unlinked internal encoders
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: calvaris, cgarcia, ews-watchlist, gustavo, menard, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
pipeline dump
none
Patch calvaris: review+, calvaris: commit-queue-

Philippe Normand
Reported 2021-06-24 10:33:23 PDT
Created attachment 432187 [details] pipeline dump Oddly this doesn't seem to introduce test failures, unless playbin3 is enabled. In some tests such as media/track/in-band/track-in-band-kate-ogg-cues-added-once.html the combiner pads can receive multiple caps events describing the same stream, that's not good because then new vtt encoders are added to the combiner and remain unlinked. See attached pipeline dump.
Attachments
pipeline dump (178.86 KB, image/svg+xml)
2021-06-24 10:33 PDT, Philippe Normand 		no flags
Details
Patch (5.74 KB, patch)
2021-06-24 10:56 PDT, Philippe Normand 		calvaris: review+
calvaris: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philippe Normand
Comment 1 2021-06-24 10:56:07 PDT
Created attachment 432191 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2021-06-25 07:16:46 PDT
Comment on attachment 432191 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=432191&action=review > Source/WebCore/platform/graphics/gstreamer/TextCombinerPadGStreamer.cpp:39 > + bool processStickyEvents { true }; shouldProcessStickyEvents
Philippe Normand
Comment 3 2021-06-25 08:39:34 PDT
Committed r279285 (239164@main): <https://commits.webkit.org/239164@main>
Radar WebKit Bug Importer
Comment 4 2021-06-25 08:40:19 PDT
<rdar://problem/79779869>
Note You need to log in before you can comment on or make changes to this bug.