| Summary: | [GStreamer] Build warnings in AudioFileReader since r279123 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Philippe Normand <pnormand> | ||||||
| Component: | Platform | Assignee: | Philippe Normand <pnormand> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | calvaris, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, vjaquez, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=227208 | ||||||||
| Attachments: |
|
||||||||
Created attachment 432150 [details]
Patch
Created attachment 432151 [details]
Patch
Committed r279283 (239162@main): <https://commits.webkit.org/239162@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432151 [details]. |
[2156/3527] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp.o ../../Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:351:9: warning: variable 'source' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] if (m_data) { ^~~~~~ ../../Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:361:131: note: uninitialized use occurs here gst_bin_add_many(((((GstBin*) g_type_check_instance_cast ((GTypeInstance*) ((m_pipeline.get())), ((gst_bin_get_type ())))))), source, m_decodebin.get(), nullptr); ^~~~~~ ../../Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:351:5: note: remove the 'if' if its condition is always true if (m_data) { ^~~~~~~~~~~~ ../../Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:350:23: note: initialize the variable 'source' to silence this warning GstElement* source; ^ = nullptr 1 warning generated.