| Summary: | Unskip arguments-properties-order.js on arm and mips | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mikhail R. Gadelha <mikhail> | ||||||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | angelos, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Mikhail R. Gadelha
2021-06-22 07:59:28 PDT
Created attachment 431965 [details]
Patch
The ChangeLog claims the patch will unskip the test "on arm and mips", but the test is only skipped on mips. What's more, as the preceding comment mentions, the issue is that the test fails on the Loongson 3A4000, which is currently assigned to the igalia-jsc32-mipsel-ews-02 worker (that's where the EWS run executed, good!) along with two ci20 boards. However there's no guarantee that the test ran on the loongson instead of the ci20 boards. If you can (manually) test on the loongson (a.k.a. "the lemote box") that'd be great! Created attachment 432038 [details]
Patch
Tested on Loongson with 50 iterations and no crash. Also removed the comment. Created attachment 432051 [details]
Patch
Created attachment 432053 [details]
Patch
Created attachment 432056 [details]
Patch
Committed r279219 (239105@main): <https://commits.webkit.org/239105@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 432056 [details]. |