Bug 227254

Summary:

Unskip arguments-properties-order.js on arm and mips

Product:

WebKit

Reporter:

Mikhail R. Gadelha <mikhail>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

angelos, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Mikhail R. Gadelha

Reported 2021-06-22 07:59:28 PDT

Unskip arguments-properties-order.js on arm and mips

Attachments
Patch (1.17 KB, patch) 2021-06-22 08:01 PDT, Mikhail R. Gadelha	no flags	Details Formatted Diff Diff
Patch (1.22 KB, patch) 2021-06-23 07:28 PDT, Mikhail R. Gadelha	no flags	Details Formatted Diff Diff
Patch (1.21 KB, patch) 2021-06-23 08:48 PDT, Mikhail R. Gadelha	no flags	Details Formatted Diff Diff
Patch (1.21 KB, patch) 2021-06-23 08:49 PDT, Mikhail R. Gadelha	no flags	Details Formatted Diff Diff
Patch (1.21 KB, patch) 2021-06-23 08:55 PDT, Mikhail R. Gadelha	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Mikhail R. Gadelha

Comment 1 2021-06-22 08:01:15 PDT

Created attachment 431965 [details] Patch

Angelos Oikonomopoulos

Comment 2 2021-06-23 06:43:27 PDT

The ChangeLog claims the patch will unskip the test "on arm and mips", but the test is only skipped on mips. What's more, as the preceding comment mentions, the issue is that the test fails on the Loongson 3A4000, which is currently assigned to the igalia-jsc32-mipsel-ews-02 worker (that's where the EWS run executed, good!) along with two ci20 boards. However there's no guarantee that the test ran on the loongson instead of the ci20 boards. If you can (manually) test on the loongson (a.k.a. "the lemote box") that'd be great!

Mikhail R. Gadelha

Comment 3 2021-06-23 07:28:08 PDT

Created attachment 432038 [details] Patch

Mikhail R. Gadelha

Comment 4 2021-06-23 07:31:09 PDT

Tested on Loongson with 50 iterations and no crash. Also removed the comment.

Mikhail R. Gadelha

Comment 5 2021-06-23 08:48:48 PDT

Created attachment 432051 [details] Patch

Mikhail R. Gadelha

Comment 6 2021-06-23 08:49:50 PDT

Created attachment 432053 [details] Patch