Summary: | [GLIB] REGRESSION(r278701): numerous WebRTC tests failing after libwebrtc update to M92 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Arcady Goldmints-Orlov <crzwdjk> | ||||||||
Component: | WebRTC | Assignee: | Philippe Normand <pnormand> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | annulen, aperez, clopez, eric.carlson, ews-watchlist, gyuyoung.kim, pnormand, ryuan.choi, sergio, webkit-bug-importer, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Linux | ||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=226488 | ||||||||||
Bug Depends on: | 227176 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Arcady Goldmints-Orlov
2021-06-18 10:59:18 PDT
Created attachment 431787 [details]
Patch
The culprit is the libwebrtc update, see for instance: https://results.webkit.org/?suite=layout-tests&test=webrtc/datachannel/basic.html Comment on attachment 431787 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431787&action=review Thanks for spotting this issue, Arcady. I found the problem, our port had data channel support disabled by mistake during the libwebrtc massive update... I have a patch fixing it, I'll likely land it unreviewed (2 lines added in a cmake file...) > LayoutTests/platform/glib/TestExpectations:1094 > -webkit.org/b/191006 webrtc/simulcast-h264.html [ Failure ] > +webkit.org/b/191006 webrtc/simulcast-h264.html [ Timeout ] The new bug should be added: webkit.org/b/227172 webkit.org/b/191006 webrtc/simulcast-h264.html [ Timeout ] > LayoutTests/platform/glib/TestExpectations:1161 > +webkit.org/b/227172 inspector/page/overrideSetting-ICECandidateFilteringEnabled.html [ Skip ] Skip should be for features not implemented by our ports. There's libvpx breakage as well indeed :( The libvpx included in the SDK is now too old for the ABI libwebrtc expects... Created attachment 431795 [details]
Patch
EWS won't pass until SDK update in bug 227176 is deployed. Created attachment 431837 [details]
Patch
Committed r279065 (238985@main): <https://commits.webkit.org/238985@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431837 [details]. *** Bug 227233 has been marked as a duplicate of this bug. *** |