Bug 227172

Summary:

[GLIB] REGRESSION(r278701): numerous WebRTC tests failing after libwebrtc update to M92

Product:

WebKit

Reporter:

Arcady Goldmints-Orlov <crzwdjk>

Component:

WebRTC

Assignee:

Philippe Normand <pnormand>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, aperez, clopez, eric.carlson, ews-watchlist, gyuyoung.kim, pnormand, ryuan.choi, sergio, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Linux

See Also:

https://bugs.webkit.org/show_bug.cgi?id=226488

Bug Depends on:

227176

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-

Arcady Goldmints-Orlov

Reported 2021-06-18 10:59:18 PDT

The change in r278564 which updated libvpx has caused a number of WebRTC tests to start either failing or timing out on both GTK and WPE.

Attachments
Patch (6.21 KB, patch) 2021-06-18 13:52 PDT, Arcady Goldmints-Orlov	no flags	Details Formatted Diff Diff
Patch (2.45 KB, patch) 2021-06-19 09:15 PDT, Philippe Normand	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (2.45 KB, patch) 2021-06-21 01:37 PDT, Philippe Normand	ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Arcady Goldmints-Orlov

Comment 1 2021-06-18 13:52:06 PDT

Created attachment 431787 [details] Patch

Philippe Normand

Comment 2 2021-06-19 01:25:24 PDT

The culprit is the libwebrtc update, see for instance: https://results.webkit.org/?suite=layout-tests&test=webrtc/datachannel/basic.html

Philippe Normand

Comment 3 2021-06-19 01:45:53 PDT

Comment on attachment 431787 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=431787&action=review Thanks for spotting this issue, Arcady. I found the problem, our port had data channel support disabled by mistake during the libwebrtc massive update... I have a patch fixing it, I'll likely land it unreviewed (2 lines added in a cmake file...) > LayoutTests/platform/glib/TestExpectations:1094 > -webkit.org/b/191006 webrtc/simulcast-h264.html [ Failure ] > +webkit.org/b/191006 webrtc/simulcast-h264.html [ Timeout ] The new bug should be added: webkit.org/b/227172 webkit.org/b/191006 webrtc/simulcast-h264.html [ Timeout ] > LayoutTests/platform/glib/TestExpectations:1161 > +webkit.org/b/227172 inspector/page/overrideSetting-ICECandidateFilteringEnabled.html [ Skip ] Skip should be for features not implemented by our ports.

Philippe Normand

Comment 4 2021-06-19 03:10:02 PDT

There's libvpx breakage as well indeed :( The libvpx included in the SDK is now too old for the ABI libwebrtc expects...

Philippe Normand

Comment 5 2021-06-19 09:15:44 PDT

Created attachment 431795 [details] Patch

Philippe Normand

Comment 6 2021-06-19 09:16:15 PDT

EWS won't pass until SDK update in bug 227176 is deployed.

Philippe Normand

Comment 7 2021-06-21 01:37:20 PDT

Created attachment 431837 [details] Patch

EWS

Comment 8 2021-06-21 03:13:34 PDT

Committed r279065 (238985@main): <https://commits.webkit.org/238985@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431837 [details].

Radar WebKit Bug Importer

Comment 9 2021-06-21 03:14:36 PDT

<rdar://problem/79554664>

Carlos Alberto Lopez Perez

Comment 10 2021-06-21 18:57:42 PDT

*** Bug 227233 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.