Bug 227155

Summary: jitCompileAndSetHeuristics shouldn't return true when we fail to compile
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
patch
tzagallo: review+, ews-feeder: commit-queue-
patch for landing none

Saam Barati
Reported 2021-06-17 16:59:47 PDT
...
Attachments
WIP (32.96 KB, patch)
2021-06-17 19:19 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (36.49 KB, patch)
2021-06-21 16:24 PDT, Saam Barati 		tzagallo: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
patch for landing (36.71 KB, patch)
2021-06-21 16:50 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2021-06-17 19:19:05 PDT
Created attachment 431749 [details] WIP
Saam Barati
Comment 2 2021-06-21 16:24:22 PDT
Created attachment 431926 [details] patch
Saam Barati
Comment 3 2021-06-21 16:24:38 PDT
Comment on attachment 431926 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=431926&action=review > Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:381 > + if (codeBlock->jitType() == JITType::BaselineJIT) { This is the bug fix
Tadeu Zagallo
Comment 4 2021-06-21 16:47:10 PDT
Comment on attachment 431926 [details] patch LGTM, might be worth pointing out in the ChangeLog why the new fuzzer is in this patch.
Saam Barati
Comment 5 2021-06-21 16:50:42 PDT
Created attachment 431930 [details] patch for landing
EWS
Comment 6 2021-06-22 10:48:51 PDT
Committed r279126 (239041@main): <https://commits.webkit.org/239041@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 431930 [details].
Radar WebKit Bug Importer
Comment 7 2021-06-22 10:49:21 PDT
<rdar://problem/79622554>
Note You need to log in before you can comment on or make changes to this bug.