Bug 227155

Summary: jitCompileAndSetHeuristics shouldn't return true when we fail to compile
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, mark.lam, msaboff, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP
none
patch
tzagallo: review+, ews-feeder: commit-queue-
patch for landing none

Description Saam Barati 2021-06-17 16:59:47 PDT 
...
Comment 1 Saam Barati 2021-06-17 19:19:05 PDT 
Created attachment 431749 [details]
WIP
Comment 2 Saam Barati 2021-06-21 16:24:22 PDT 
Created attachment 431926 [details]
patch
Comment 3 Saam Barati 2021-06-21 16:24:38 PDT 
Comment on attachment 431926 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431926&action=review

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:381
> +    if (codeBlock->jitType() == JITType::BaselineJIT) {

This is the bug fix
Comment 4 Tadeu Zagallo 2021-06-21 16:47:10 PDT 
Comment on attachment 431926 [details]
patch

LGTM, might be worth pointing out in the ChangeLog why the new fuzzer is in this patch.
Comment 5 Saam Barati 2021-06-21 16:50:42 PDT 
Created attachment 431930 [details]
patch for landing
Comment 6 EWS 2021-06-22 10:48:51 PDT 
Committed r279126 (239041@main): <https://commits.webkit.org/239041@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 431930 [details].
Comment 7 Radar WebKit Bug Importer 2021-06-22 10:49:21 PDT 
<rdar://problem/79622554>