Bug 227147

Summary:

Define MacroAssemblerARM64E::numberOfPACBits based on OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH).

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	ews-feeder: commit-queue-
proposed patch.	ews-feeder: commit-queue-
proposed patch.	saam: review+

Mark Lam

Reported 2021-06-17 14:45:38 PDT

Also define OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH) based on MACH_VM_MAX_ADDRESS for OS(DARWIN). rdar://78785309

Attachments
proposed patch. (14.10 KB, patch) 2021-06-17 14:57 PDT, Mark Lam	ews-feeder: commit-queue-	Details Formatted Diff Diff
proposed patch. (17.42 KB, patch) 2021-06-17 15:28 PDT, Mark Lam	ews-feeder: commit-queue-	Details Formatted Diff Diff
proposed patch. (18.01 KB, patch) 2021-06-17 15:39 PDT, Mark Lam	saam: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2021-06-17 14:57:29 PDT

Created attachment 431725 [details] proposed patch.

Mark Lam

Comment 2 2021-06-17 15:28:45 PDT

Created attachment 431729 [details] proposed patch.

Mark Lam

Comment 3 2021-06-17 15:39:44 PDT

Created attachment 431731 [details] proposed patch.

Saam Barati

Comment 4 2021-06-17 16:01:13 PDT

Comment on attachment 431731 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=431731&action=review > Source/WTF/wtf/CagedPtr.h:48 > + static constexpr unsigned numberOfPACBits = numberOfPointerBits - OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH); would be good if we eventually renamed this to "maximumNumberOfAllowedPACBits" or similar

Mark Lam

Comment 5 2021-06-17 16:02:05 PDT

(In reply to Saam Barati from comment #4) > Comment on attachment 431731 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431731&action=review > > > Source/WTF/wtf/CagedPtr.h:48 > > + static constexpr unsigned numberOfPACBits = numberOfPointerBits - OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH); > > would be good if we eventually renamed this to > "maximumNumberOfAllowedPACBits" or similar I can do that in a follow up patch.

Mark Lam

Comment 6 2021-06-17 18:45:53 PDT

Thanks for the review. Landed in r279028: <http://trac.webkit.org/r279028>.

Note You need to log in before you can comment on or make changes to this bug.