Bug 227147

Summary: Define MacroAssemblerARM64E::numberOfPACBits based on OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH).
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, msaboff, sbarati, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
ews-feeder: commit-queue-
proposed patch.
ews-feeder: commit-queue-
proposed patch. sbarati: review+

Description Mark Lam 2021-06-17 14:45:38 PDT
Also define OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH) based on MACH_VM_MAX_ADDRESS for OS(DARWIN).

rdar://78785309
Comment 1 Mark Lam 2021-06-17 14:57:29 PDT
Created attachment 431725 [details]
proposed patch.
Comment 2 Mark Lam 2021-06-17 15:28:45 PDT
Created attachment 431729 [details]
proposed patch.
Comment 3 Mark Lam 2021-06-17 15:39:44 PDT
Created attachment 431731 [details]
proposed patch.
Comment 4 Saam Barati 2021-06-17 16:01:13 PDT
Comment on attachment 431731 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=431731&action=review

> Source/WTF/wtf/CagedPtr.h:48
> +    static constexpr unsigned numberOfPACBits = numberOfPointerBits - OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH);

would be good if we eventually renamed this to "maximumNumberOfAllowedPACBits" or similar
Comment 5 Mark Lam 2021-06-17 16:02:05 PDT
(In reply to Saam Barati from comment #4)
> Comment on attachment 431731 [details]
> proposed patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=431731&action=review
> 
> > Source/WTF/wtf/CagedPtr.h:48
> > +    static constexpr unsigned numberOfPACBits = numberOfPointerBits - OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH);
> 
> would be good if we eventually renamed this to
> "maximumNumberOfAllowedPACBits" or similar

I can do that in a follow up patch.
Comment 6 Mark Lam 2021-06-17 18:45:53 PDT
Thanks for the review.  Landed in r279028: <http://trac.webkit.org/r279028>.