Summary: | Define MacroAssemblerARM64E::numberOfPACBits based on OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH). | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Mark Lam
2021-06-17 14:45:38 PDT
Created attachment 431725 [details]
proposed patch.
Created attachment 431729 [details]
proposed patch.
Created attachment 431731 [details]
proposed patch.
Comment on attachment 431731 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=431731&action=review > Source/WTF/wtf/CagedPtr.h:48 > + static constexpr unsigned numberOfPACBits = numberOfPointerBits - OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH); would be good if we eventually renamed this to "maximumNumberOfAllowedPACBits" or similar (In reply to Saam Barati from comment #4) > Comment on attachment 431731 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=431731&action=review > > > Source/WTF/wtf/CagedPtr.h:48 > > + static constexpr unsigned numberOfPACBits = numberOfPointerBits - OS_CONSTANT(EFFECTIVE_ADDRESS_WIDTH); > > would be good if we eventually renamed this to > "maximumNumberOfAllowedPACBits" or similar I can do that in a follow up patch. Thanks for the review. Landed in r279028: <http://trac.webkit.org/r279028>. |