Bug 227145

Summary:

[iOS] Increase contrast for textfields, checkboxes, and radio buttons

Product:

WebKit

Reporter:

James Craig <jcraig>

Component:

Forms

Assignee:

Aditya Keerthi <akeerthi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

akeerthi, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	wenson_hsieh: review+
Patch for landing	none

Description James Craig 2021-06-17 14:27:19 PDT

The textfield issue is being worked out in bug 227135, but the contrast of checkboxes and other controls are still using -apple-system-opaque-fill rather than -apple-system-opaque-separator or another more appropriate and higher contrast system color.

Comment 1 James Craig 2021-06-17 14:28:31 PDT

The extreme low contrast problem was called out today in https://twitter.com/gerireid/status/1405203573269569538

Comment 2 Radar WebKit Bug Importer 2021-06-17 14:31:23 PDT

<rdar://problem/79470926>

Comment 3 Aditya Keerthi 2021-07-08 13:13:26 PDT

Created attachment 433160 [details]
Patch

Comment 4 Wenson Hsieh 2021-07-09 11:18:46 PDT

Comment on attachment 433160 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433160&action=review

> Source/WebCore/rendering/RenderThemeIOS.mm:2090
> +

Nit - you could probably pull `checkboxRadioBackgroundColor(controlStates, styleColorOptions)` out into a local variable here to avoid writing it out twice.

> Source/WebCore/rendering/RenderThemeIOS.mm:2155
> +        context.setFillColor(checkboxRadioBackgroundColor(controlStates, styleColorOptions));

(Ditto)

Comment 5 Aditya Keerthi 2021-07-09 11:34:18 PDT

Created attachment 433229 [details]
Patch for landing

Comment 6 EWS 2021-07-09 14:47:27 PDT

Committed r279795 (239562@main): <https://commits.webkit.org/239562@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433229 [details].