Bug 227145

Summary: [iOS] Increase contrast for textfields, checkboxes, and radio buttons
Product: WebKit Reporter: James Craig <jcraig>
Component: FormsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: akeerthi, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, pdr, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
wenson_hsieh: review+
Patch for landing none

James Craig
Reported 2021-06-17 14:27:19 PDT
The textfield issue is being worked out in bug 227135, but the contrast of checkboxes and other controls are still using -apple-system-opaque-fill rather than -apple-system-opaque-separator or another more appropriate and higher contrast system color.
Attachments
Patch (294.70 KB, patch)
2021-07-08 13:13 PDT, Aditya Keerthi 		wenson_hsieh: review+
DetailsFormatted DiffDiff
Patch for landing (294.69 KB, patch)
2021-07-09 11:34 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Craig
Comment 1 2021-06-17 14:28:31 PDT
The extreme low contrast problem was called out today in https://twitter.com/gerireid/status/1405203573269569538
Radar WebKit Bug Importer
Comment 2 2021-06-17 14:31:23 PDT
<rdar://problem/79470926>
Aditya Keerthi
Comment 3 2021-07-08 13:13:26 PDT
Created attachment 433160 [details] Patch
Wenson Hsieh
Comment 4 2021-07-09 11:18:46 PDT
Comment on attachment 433160 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433160&action=review > Source/WebCore/rendering/RenderThemeIOS.mm:2090 > + Nit - you could probably pull `checkboxRadioBackgroundColor(controlStates, styleColorOptions)` out into a local variable here to avoid writing it out twice. > Source/WebCore/rendering/RenderThemeIOS.mm:2155 > + context.setFillColor(checkboxRadioBackgroundColor(controlStates, styleColorOptions)); (Ditto)
Aditya Keerthi
Comment 5 2021-07-09 11:34:18 PDT
Created attachment 433229 [details] Patch for landing
EWS
Comment 6 2021-07-09 14:47:27 PDT
Committed r279795 (239562@main): <https://commits.webkit.org/239562@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433229 [details].
Note You need to log in before you can comment on or make changes to this bug.